actions/cargo-semver-checks
actions/cargo-semver-checks
3
0
Fork 0
mirror of https://github.com/obi1kenobi/cargo-semver-checks-action.git synced 2024-11-22 16:09:33 +01:00
Code Issues Projects Activity Pipelines

Update cache keys in test-inputs.yml (#79)

Browse source 
It's always caching. Or DNS. This time it was caching.

A while back, we changed the default cache key prefix from empty-string to `semver` so that our cache key names don't start with a dash, since users found that confusing.

We should have updated these tests accordingly at the time, but we did not. So how did the PR with the change pass?

It used the caches from older runs of the same job which used the old names. When those caches expired and were GC'd by GitHub, the jobs started failing.

This is what broke CI for #77. This PR will fix it.
This commit is contained in:
Predrag Gruevski 2024-07-02 10:47:48 -04:00 committed by GitHub
parent c7306483f6
commit 300d7d49b9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
.github/workflows/test-inputs.yml vendored
View file

@ -286,9 +286,9 @@ jobs:
path: ${{ github.workspace }}/semver-checks/target/semver-checks/cache path: ${{ github.workspace }}/semver-checks/target/semver-checks/cache
fail-on-cache-miss: true fail-on-cache-miss: true
lookup-only: true lookup-only: true
key: -${{ github.job }} key: semver-${{ github.job }}
restore-keys: | restore-keys: |
-${{ github.job }} semver-${{ github.job }}
- name: Fail if the toolchain used by the action is invalid - name: Fail if the toolchain used by the action is invalid
if: ${{ ! contains(steps.get-cache-key.outputs.cache-matched-key, 'nightly') }} if: ${{ ! contains(steps.get-cache-key.outputs.cache-matched-key, 'nightly') }}
run: | run: |
@ -329,9 +329,9 @@ jobs:
path: ${{ github.workspace }}/semver-checks/target/semver-checks/cache path: ${{ github.workspace }}/semver-checks/target/semver-checks/cache
fail-on-cache-miss: true fail-on-cache-miss: true
lookup-only: true lookup-only: true
key: -${{ github.job }} key: semver-${{ github.job }}
restore-keys: | restore-keys: |
-${{ github.job }} semver-${{ github.job }}
- name: Fail if the toolchain used by the action is invalid - name: Fail if the toolchain used by the action is invalid
if: ${{ ! contains(steps.get-cache-key.outputs.cache-matched-key, 'nightly') }} if: ${{ ! contains(steps.get-cache-key.outputs.cache-matched-key, 'nightly') }}
run: | run: |
@ -372,9 +372,9 @@ jobs:
path: ${{ github.workspace }}/semver-checks/target/semver-checks/cache path: ${{ github.workspace }}/semver-checks/target/semver-checks/cache
fail-on-cache-miss: true fail-on-cache-miss: true
lookup-only: true lookup-only: true
key: -${{ github.job }} key: semver-${{ github.job }}
restore-keys: | restore-keys: |
-${{ github.job }} semver-${{ github.job }}
- name: Fail if the toolchain used by the action is invalid - name: Fail if the toolchain used by the action is invalid
if: ${{ ! contains(steps.get-cache-key.outputs.cache-matched-key, 'beta') }} if: ${{ ! contains(steps.get-cache-key.outputs.cache-matched-key, 'beta') }}
run: | run: |